Skip to content

Ensure a goodbye packet is sent when a client is disconnected#787

Merged
notfood merged 2 commits intorwmt:devfrom
mibac138:disconnect
Apr 3, 2026
Merged

Ensure a goodbye packet is sent when a client is disconnected#787
notfood merged 2 commits intorwmt:devfrom
mibac138:disconnect

Conversation

@mibac138
Copy link
Copy Markdown
Member

@mibac138 mibac138 commented Nov 5, 2025

No description provided.

The only reliable way to actually send a packet before closing the
connection in LiteNetLib is to pass it to the Disconnect method.
matthewwachter added a commit to matthewwachter/Multiplayer that referenced this pull request Feb 19, 2026
…nnect

Squashed from rwmt#787 (commits 4ea4a6f, 0442adf):
- Ensure a goodbye packet is sent when a client is disconnected
- Remove GetDisconnectBytes in favor of ServerDisconnectPacket
@notfood notfood added enhancement New feature or request. 1.6 Fixes or bugs relating to 1.6 (Not Odyssey). labels Apr 3, 2026
@notfood notfood moved this to In review in 1.6 and Odyssey Apr 3, 2026
@notfood
Copy link
Copy Markdown
Member

notfood commented Apr 3, 2026

I don't remember why this didn't get merged. Still good?

@mibac138
Copy link
Copy Markdown
Member Author

mibac138 commented Apr 3, 2026

Yup, should still be good and help fix the issue where users directly connecting just see a Disconnected message with no explanation

@notfood notfood merged commit af5d1a7 into rwmt:dev Apr 3, 2026
1 check passed
@github-project-automation github-project-automation bot moved this from In review to Done in 1.6 and Odyssey Apr 3, 2026
@mibac138 mibac138 deleted the disconnect branch April 3, 2026 23:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

1.6 Fixes or bugs relating to 1.6 (Not Odyssey). enhancement New feature or request.

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants